Open
Conversation
sata-form3
force-pushed
the
sata-fix-tests-master
branch
from
c72bf41 to
b7bf650
Compare
- Also include report-format for undercover to produce a better output and remove warnings around lacking configuration. - bump Emacs version to 29.1 - Upgrade Actions to newer version that exist for node16 deprecation - Run tests on Pull Requests Signed-off-by: Sam Tavakoli <sam.tavakoli@form3.tech>
This reverts commit 891d84c. gotest.el depends on `go-end-of-defun` in `go-test--get-current-data`. Without the go-mode dependency we see a warning: `gotest.el:282:33: Warning: the function ‘go-end-of-defun’ is not known to be defined.` And failing test: Test failed: ((should (string= "TestFoo|TestBar|Test_Baz" (go-test--get-current-file-tests))) :form (string= "TestFoo|TestBar|Test_Baz" nil) :value nil :explanation (arrays-of-different-length 24 3 "TestFoo|TestBar|Test_Baz" "nil" first-mismatch-at 0)) where `go-test--get-current-file-tests` will now return nil instead of expected values. By reintroducing the dependency we solve this issue. Signed-off-by: Sam Tavakoli <sam.tavakoli@form3.tech>
- Emacs 29.1 complained about redefined test cases. - Using unique names across tests - Correct args test Signed-off-by: Sam Tavakoli <sam.tavakoli@form3.tech>
sata-form3
force-pushed
the
sata-fix-tests-master
branch
from
4209f34 to
b388b7b
Compare
Author
|
@nlamirault Any chance you can review this when you have time? I would like to introduce an extra flag for |
nanjj
reviewed
Apr 25, 2025
| (require 's) | ||
| (require 'f) | ||
| (require 'cl-lib) | ||
| (require 'go-mode) |
Contributor
There was a problem hiding this comment.
Why add go-mode require back?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI pipeline didn't seem to work when I wanted to introduce a change, this PR is to bring back passing tests on Master.
EDIT: Follow up with this would be to enable
run testsas astatus checkfor merging PRs