Skip to content

[CodeClean] handle error case #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaeyun-jung merged 1 commit into from
Feb 12, 2025
Merged

[CodeClean] handle error case #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions daemon/mlops-agent-node.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ mlops_node_create (const gchar * name, const mlops_node_type_e type,
GError *err = NULL;
GstStateChangeReturn ret;

g_return_val_if_fail (id != NULL, -EINVAL);

switch (type) {
case MLOPS_NODE_TYPE_PIPELINE:
{
Expand All @@ -173,9 +175,6 @@ mlops_node_create (const gchar * name, const mlops_node_type_e type,
desc, (err) ? err->message : "unknown reason");
g_clear_error (&err);

if (pipeline)
gst_object_unref (pipeline);

result = -ESTRPIPE;
goto error;
}
Expand All @@ -186,12 +185,11 @@ mlops_node_create (const gchar * name, const mlops_node_type_e type,
ml_loge
("Failed to set the state of the pipeline to PAUSED. For the detail, please check the GStreamer log message.");

gst_object_unref (pipeline);
result = -ESTRPIPE;
goto error;
}

/* Add node info into hash table. */
/* Final step, add node info into hash table. */
node = g_new0 (mlops_node_s, 1);
node->type = type;
node->id = g_get_monotonic_time ();
Expand All @@ -204,12 +202,12 @@ mlops_node_create (const gchar * name, const mlops_node_type_e type,
g_hash_table_insert (g_mlops_node_table, GINT_TO_POINTER (node->id), node);
G_UNLOCK (mlops_node_table);

*id = node->id;

error:
if (result == 0) {
*id = node->id;
} else {
if (node)
_mlops_node_free (node);
if (result != 0) {
if (pipeline)
gst_object_unref (pipeline);
}

g_free (desc);
Expand Down