Open
Conversation
Member
|
Hi, thanks for this. Please have a read of our contributing guide in the main node-red/node-red repository - something we ought to have a version of in this repo. Essentially, we prefer things to be discussed via issue or mailinglist before a pull-request is raised so that we can agree if the if the desired functionality fits in with what we have planned and what is being worked on. The bigger item is that we also require a signed contributor agreement before we can accept any PR. Full details in node-red/node-red/CONTRIBUTING.md. On this specific issue, assuming we resolve the points above, the interval presented to the user should be in minutes - not milliseconds as the underlying code uses. Let me know how you'd like to proceed. Nick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an interval property to allow the user to choose when the watcher checks for change