Merged
Conversation
Owner
nojimage
commented
Dec 2, 2025
- fixes Twitter\Text\Configuration::__construct(): Implicitly marking parameter $config as nullable is deprecated, the explicit nullable type must be used instead #48
…er-text dependencies for compatibility
7e8f770 to
46c1732
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for PHP 8.4 by updating type hints to use modern nullable syntax, updating dependencies, and modernizing the CI configuration.
Key Changes:
- Updated type hints across multiple classes to use nullable syntax (
?Type) instead of docblock-only type hints - Updated CI workflow to test PHP versions 7.4 through 8.5, with PHP 8.4 as the default for coverage and code style checks
- Updated dependencies to support newer versions of symfony/yaml and twitter/twitter-text
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/bootstrap.php | Removed deprecated E_STRICT constant from error reporting |
| lib/Twitter/Text/Validator.php | Added nullable type hints and updated return type annotations to use self |
| lib/Twitter/Text/Parser.php | Added nullable type hints and updated return type annotations to use self |
| lib/Twitter/Text/HitHighlighter.php | Added nullable type hints and updated return type annotations to use self |
| lib/Twitter/Text/Extractor.php | Updated return type annotation to use self |
| lib/Twitter/Text/Configuration.php | Added nullable type hints, updated return type annotations to use self, and changed instantiation to use self |
| lib/Twitter/Text/Autolink.php | Added nullable type hints and updated return type annotations to use static |
| composer.json | Updated symfony/yaml and twitter/twitter-text version constraints |
| .github/workflows/ci.yml | Updated to test PHP 8.3-8.5, modernized GitHub Actions, and improved CI configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.