Merged
Conversation
…ature Signing both Versions/B and the top-level Sparkle.framework symlink signs the same directory twice, invalidating the first signature and producing "The signature of the binary is invalid" errors during notarization. Only sign Versions/B directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add .gitmodules with all 7 submodule URLs (Fuzi, Highlightr, LRUCache, Motion, reeeed, swift-atomics, swift-numerics) so git branch operations (e.g. checkout gh-pages) don't fatal on missing submodule URLs - Explicitly sign Sparkle.framework/Versions/B/Sparkle dylib before signing the framework version bundle — omitting this caused the dylib to have an invalid signature under notarization scrutiny - Add pre-notarize codesign --verify step to catch signing failures before wasting a notarization submission Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdates macOS code signing workflow steps in the notarization pipeline to sign Sparkle dylib and framework version separately, adds verification step for Nook.app signature, and introduces nine new git submodule dependencies including Fuzi, Highlightr, LRUCache, and Apple's swift-numerics and swift-atomics libraries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit