fix: use ditto for notarization archive and add runtime flag to Sparkle#326
Merged
jonathancaudill merged 1 commit intomainfrom Feb 28, 2026
Merged
fix: use ditto for notarization archive and add runtime flag to Sparkle#326jonathancaudill merged 1 commit intomainfrom
jonathancaudill merged 1 commit intomainfrom
Conversation
zip -r dereferences symlinks (e.g. Sparkle.framework/Sparkle becomes a regular file copy) which breaks the bundle code seal — Apple's verifier checks that sealed symlinks are still symlinks, so it flags MacOS/Nook (where the bundle signature lives) and Sparkle.framework/Sparkle as having invalid signatures. ditto -c -k --keepParent preserves symlinks, extended attributes, and all macOS filesystem metadata required for valid notarization archives. Also add --options runtime to the Sparkle.framework/Versions/B signing step so the framework dylib passes Apple's hardened runtime check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request updates the macOS notarization workflow to enhance code signing security and archive integrity. The changes add the hardened runtime option to codesign operations for both the Sparkle framework and main application, while replacing zip with ditto for archiving to preserve macOS symlinks and extended attributes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zip -r dereferences symlinks (e.g. Sparkle.framework/Sparkle becomes a regular file copy) which breaks the bundle code seal — Apple's verifier checks that sealed symlinks are still symlinks, so it flags MacOS/Nook (where the bundle signature lives) and Sparkle.framework/Sparkle as having invalid signatures.
ditto -c -k --keepParent preserves symlinks, extended attributes, and all macOS filesystem metadata required for valid notarization archives.
Also add --options runtime to the Sparkle.framework/Versions/B signing step so the framework dylib passes Apple's hardened runtime check.
Summary by CodeRabbit