Use default AWS creds chain to support EKS Pod Identity#2446
Open
ryangoldblatt-bm wants to merge 1 commit intonotaryproject:v1-devfrom
Open
Use default AWS creds chain to support EKS Pod Identity#2446ryangoldblatt-bm wants to merge 1 commit intonotaryproject:v1-devfrom
ryangoldblatt-bm wants to merge 1 commit intonotaryproject:v1-devfrom
Conversation
Signed-off-by: Ryan Goldblatt <ryan.goldblatt@bitmex.com>
45e5634 to
524b0f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use default AWS credentials chain to support EKS Pod Identity.
Currently the AWS authentication is hard-coded to support IRSA only by checking for injected env variables
AWS_WEB_IDENTITY_TOKEN_FILEandAWS_ROLE_ARN.These changes use the default AWS credentials chain which also supports EKS Pod Identity (which inject env variable
AWS_CONTAINER_AUTHORIZATION_TOKEN_FILEinstead).Pod Identity is a simpler approach in EKS than IRSA since OIDC identity providers are not needed, see here.
Which issue(s) does this PR resolve?
n/a
Type of change
Testing and verification
Related unit test passes:
We've also build and tested this patch in our environment which now enables Ratify to use EKS Pod Identity rather the IRSA to authenticate to our ECR repo.
Checklist
Post merge requirements
Helm Chart Change