feat: add skill command to install/remove notte skill via npx#40
Merged
giordano-lucas merged 3 commits intomainfrom Feb 3, 2026
Merged
feat: add skill command to install/remove notte skill via npx#40giordano-lucas merged 3 commits intomainfrom
giordano-lucas merged 3 commits intomainfrom
Conversation
Adds `notte skill add` and `notte skill remove` commands that proxy to `npx skills add/remove nottelabs/notte-cli` for installing the Notte browser automation skill in AI coding assistants. Includes prerequisite checks for npx and the skills package with helpful error messages if dependencies are missing.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
internal/cmd/skills.go
Outdated
Comment on lines
56
to
60
| // Check if skills package is available by running 'npx skills --version' | ||
| cmd := exec.Command("npx", "skills", "--version") | ||
| if err := cmd.Run(); err != nil { | ||
| return errors.New("'skills' package not found. Install it with: npm install -g skills") | ||
| } |
There was a problem hiding this comment.
npx skills --version will download and execute the skills package if not installed, making this not a true "check". Consider checking if the package is locally installed first or removing this check entirely since npx is designed to work without pre-installation.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/cmd/skills.go
Line: 56:60
Comment:
`npx skills --version` will download and execute the skills package if not installed, making this not a true "check". Consider checking if the package is locally installed first or removing this check entirely since `npx` is designed to work without pre-installation.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
internal/cmd/skills.go
Outdated
| // Check if skills package is available by running 'npx skills --version' | ||
| cmd := exec.Command("npx", "skills", "--version") | ||
| if err := cmd.Run(); err != nil { | ||
| return errors.New("'skills' package not found. Install it with: npm install -g skills") |
There was a problem hiding this comment.
Confusing error message - npx doesn't require global installation. Either remove the check above or clarify that global installation is optional.
Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/cmd/skills.go
Line: 59:59
Comment:
Confusing error message - `npx` doesn't require global installation. Either remove the check above or clarify that global installation is optional.
How can I resolve this? If you propose a fix, please make it concise.Remove the skills package check since npx auto-downloads packages, making the check ineffective.
Member
Author
|
@greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
notte skill addandnotte skill removecommands that proxy tonpx skills add/remove nottelabs/notte-clifor installing the Notte browser automation skill in AI coding assistants.Includes prerequisite checks for npx and the skills package with helpful error messages if dependencies are missing.
Greptile Overview
Greptile Summary
This PR adds
notte skill addandnotte skill removecommands that proxy tonpx skills add/remove nottelabs/notte-clifor installing the Notte browser automation skill in AI coding assistants. The implementation is clean and straightforward, properly handling stdin/stdout/stderr for interactive npx commands.exec.CommandContextfor cancellation supportConfidence Score: 5/5
Important Files Changed
npx skills, clean implementation with proper I/O handling