feat: add request headers for tracking (x-notte-request-origin, x-not…#42
Merged
giordano-lucas merged 2 commits intomainfrom Feb 4, 2026
Merged
feat: add request headers for tracking (x-notte-request-origin, x-not…#42giordano-lucas merged 2 commits intomainfrom
giordano-lucas merged 2 commits intomainfrom
Conversation
…te-sdk-version) Add two headers to all API requests: - x-notte-request-origin: "cli" - x-notte-sdk-version: CLI version string Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: internal/api/client_test.go
Line: 62:88
Comment:
Missing test coverage for new tracking headers. `TestResilientTransport_AddsAuthHeader` should also verify `x-notte-request-origin` and `x-notte-sdk-version` headers are set.
How can I resolve this? If you propose a fix, please make it concise. |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…te-sdk-version)
Add two headers to all API requests:
Greptile Overview
Greptile Summary
This PR adds request tracking headers to all API requests made by the CLI. Two headers are now included:
x-notte-request-origin(set to "cli") andx-notte-sdk-version(set to the CLI version string).Changes:
NewClientWithURLto accept aversionparameterresilientTransportto store and set the version in request headersGetClient()in root.go to pass theVersionvariableObservations:
NewClient()(when not usingNewClientWithURLdirectly)Confidence Score: 4/5
Important Files Changed
x-notte-request-origin,x-notte-sdk-version) to all API requestsGetClient()to passVersionvariable to API client constructor