Skip to content

fix: remove persona phone-create and phone-delete commands#43

Merged
giordano-lucas merged 1 commit intomainfrom
remove-persona-phone-commands
Feb 4, 2026
Merged

fix: remove persona phone-create and phone-delete commands#43
giordano-lucas merged 1 commit intomainfrom
remove-persona-phone-commands

Conversation

@giordano-lucas
Copy link
Member

@giordano-lucas giordano-lucas commented Feb 4, 2026

Remove the personas phone-create and phone-delete CLI commands and exclude the /personas/{id}/sms/number endpoint from SDK generation.

Greptile Overview

Greptile Summary

This PR removes the personas phone-create and personas phone-delete CLI subcommands (and their tests), and adds /personas/{id}/sms/number to the SDK generation exclusion list.

Main issue to address: the CLI skill documentation still references the removed commands, which will lead users to run non-existent subcommands.

Confidence Score: 4/5

  • This PR is safe to merge; changes are straightforward command removals with one documentation mismatch to fix.
  • The CLI subcommands and corresponding tests are cleanly removed, and the endpoint exclusion is additive. The only concrete regression found is stale docs that still mention the removed commands; also couldn’t execute go test in this environment (no Go toolchain), so confidence isn’t 5/5.
  • skills/notte-browser/SKILL.md (stale command examples); scripts/excluded-endpoints.txt (ensure generator consumes it as intended).

Important Files Changed

Filename Overview
internal/cmd/personas.go Removes persona phone-create/phone-delete Cobra subcommands and their handlers/flags; no remaining references in this file.
internal/cmd/personas_test.go Deletes tests for removed phone-create/phone-delete handlers; remaining persona command tests unchanged.
scripts/excluded-endpoints.txt Adds /personas/{id}/sms/number to excluded endpoints list for SDK generation; effectiveness depends on regeneration pipeline.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 4, 2026

Additional Comments (1)

skills/notte-browser/SKILL.md
[P1] Docs still reference removed commands

This section still documents notte personas phone-create / phone-delete, but internal/cmd/personas.go removes those subcommands in this PR, so users copying these examples will hit “unknown command”. The docs should be updated to remove these lines (or replace with the supported alternative, if any).

Prompt To Fix With AI
This is a comment left during a code review.
Path: skills/notte-browser/SKILL.md
Line: 283:286

Comment:
[P1] Docs still reference removed commands

This section still documents `notte personas phone-create` / `phone-delete`, but `internal/cmd/personas.go` removes those subcommands in this PR, so users copying these examples will hit “unknown command”. The docs should be updated to remove these lines (or replace with the supported alternative, if any).

How can I resolve this? If you propose a fix, please make it concise.

Remove the personas phone-create and phone-delete CLI commands and
exclude the /personas/{id}/sms/number endpoint from SDK generation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@giordano-lucas giordano-lucas force-pushed the remove-persona-phone-commands branch from 9e4ef26 to 8d2b656 Compare February 4, 2026 15:06
@giordano-lucas giordano-lucas merged commit 96fe0ab into main Feb 4, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant