fix: remove persona phone-create and phone-delete commands#43
Merged
giordano-lucas merged 1 commit intomainfrom Feb 4, 2026
Merged
fix: remove persona phone-create and phone-delete commands#43giordano-lucas merged 1 commit intomainfrom
giordano-lucas merged 1 commit intomainfrom
Conversation
Additional Comments (1)
This section still documents Prompt To Fix With AIThis is a comment left during a code review.
Path: skills/notte-browser/SKILL.md
Line: 283:286
Comment:
[P1] Docs still reference removed commands
This section still documents `notte personas phone-create` / `phone-delete`, but `internal/cmd/personas.go` removes those subcommands in this PR, so users copying these examples will hit “unknown command”. The docs should be updated to remove these lines (or replace with the supported alternative, if any).
How can I resolve this? If you propose a fix, please make it concise. |
Remove the personas phone-create and phone-delete CLI commands and
exclude the /personas/{id}/sms/number endpoint from SDK generation.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9e4ef26 to
8d2b656
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the personas phone-create and phone-delete CLI commands and exclude the /personas/{id}/sms/number endpoint from SDK generation.
Greptile Overview
Greptile Summary
This PR removes the
personas phone-createandpersonas phone-deleteCLI subcommands (and their tests), and adds/personas/{id}/sms/numberto the SDK generation exclusion list.Main issue to address: the CLI skill documentation still references the removed commands, which will lead users to run non-existent subcommands.
Confidence Score: 4/5
go testin this environment (no Go toolchain), so confidence isn’t 5/5.Important Files Changed