Implement dipose pattern in NpgsqlDataSourceManager #3564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusber
force-pushed
the
mb/disposeDataSourceManager
branch
from
21a81ec to
1829852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon the
NpgsqlDataSourceManagerand noticed the Dispose-pattern could be improved.Since it is an internal api it should perhaps be made 'sealed' and remove the
virtualkeywords instead of this. That would however be a more breaking change than this is. If kept, the documentation should perhaps be updated as well?Not sure if you're interested, but since I changed it I may as well post it.