Skip to content

Change migration SQL to include CASCADE for CREATE EXTENSION #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 2 commits into from
Dec 10, 2025
Merged

Change migration SQL to include CASCADE for CREATE EXTENSION #3684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63f7e5b
Change migration SQL to include CASCADE for CREATE EXTENSION
mguinness Dec 9, 2025
61ad1b8
Made extension SQL changes for tests
mguinness Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.PG/Migrations/NpgsqlMigrationsSqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,7 @@ protected virtual void GenerateCreateExtension(
.Append(DelimitIdentifier(extension.Version));
}

builder.AppendLine(";");
builder.AppendLine(" CASCADE;");
}

#region Collation management
Expand Down
4 changes: 2 additions & 2 deletions test/EFCore.PG.FunctionalTests/Migrations/MigrationsNpgsqlTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2688,7 +2688,7 @@ await Test(
Assert.Equal("public", citext.Schema);
});

AssertSql("CREATE EXTENSION IF NOT EXISTS citext;");
AssertSql("CREATE EXTENSION IF NOT EXISTS citext CASCADE;");
}

[Fact]
Expand All @@ -2714,7 +2714,7 @@ IF NOT EXISTS(SELECT 1 FROM pg_namespace WHERE nspname = 'some_schema') THEN
END $EF$;
""",
//
@"CREATE EXTENSION IF NOT EXISTS citext SCHEMA some_schema;");
@"CREATE EXTENSION IF NOT EXISTS citext SCHEMA some_schema CASCADE;");
}

#endregion
Expand Down