Skip to content

Conversation

@vinnymac
Copy link
Contributor

Configures localias so developers can utilize https://npmx.test locally, which also makes it easier to test on mobile devices without having to get fancy with tunnels or wired connections.

image

See CONTRIBUTING.md for "Custom Local Domain" usage instructions.


  • includes a warning about AtProto redirect uris bringing you back to 127
  • includes warnings for unsupported systems like windows with some recommendations, such as using WSL2
  • native macOS / linux support of course
  • configures nuxt to allow .test domains

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 7:33pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 7:33pm
npmx-lunaria Ignored Ignored Feb 11, 2026 7:33pm

Request Review

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

Adds local development domain support using Localias: adds .localias.yml mapping npmx.test to http://127.0.0.1:3000; new setup script scripts/setup-local-domain.sh to detect OS, ensure Localias is installed, configure capabilities, manage the daemon and create the alias; npm scripts setup:local and setup:local:uninstall; Vite allowedHosts: ['.test'] in nuxt.config.ts; .gitignore entries for local certs and .localias-certs/; CONTRIBUTING.md guidance for setup/uninstall; and knip.ts updated to ignore the localias binary.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, describing the addition of localias configuration for npmx.test local development across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
scripts/setup-local-domain.sh (2)

64-65: Consider portability improvements for which and getcap.

  • which is not POSIX-compliant and behaves inconsistently across systems; command -v is preferred.
  • getcap may not be installed on minimal Linux distributions (requires libcap package).
♻️ Suggested improvement
-    LOCALIAS_PATH=$(which localias)
-    if ! getcap "$LOCALIAS_PATH" 2>/dev/null | grep -q "cap_net_bind_service"; then
+    LOCALIAS_PATH=$(command -v localias)
+    if ! command -v getcap &>/dev/null; then
+        echo -e "${Y}⚠ getcap not found, skipping capability check${NC}"
+        echo "Install libcap (e.g., apt install libcap2-bin) for automatic capability management"
+    elif ! getcap "$LOCALIAS_PATH" 2>/dev/null | grep -q "cap_net_bind_service"; then

84-84: Add -r flag to read to prevent backslash interpretation.

Although unlikely to cause issues here (user is just pressing Enter), using read -r is a shell best practice to prevent backslash escape interpretation.

♻️ Suggested fix
-    read -p "Press Enter to continue or Ctrl+C to cancel... "
+    read -rp "Press Enter to continue or Ctrl+C to cancel... "

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant