Skip to content

fix: update transition end logic in modal #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexdln wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −6
Draft

fix: update transition end logic in modal #1396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions app/components/Modal.client.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,7 @@ function handleModalClose() {
* This is used by consumers that need to run layout-sensitive logic (for example
* dispatching a resize) only after the modal is fully displayed.
*/
function onDialogTransitionEnd(event: TransitionEvent) {
const el = dialogRef.value
if (!el) return
if (!el.open) return
if (event.target !== el) return
if (event.propertyName !== 'opacity') return
function onDialogTransitionEnd() {
emit('transitioned')
}

Expand Down
Loading