Timer: Cleanup and fix millis() rollover bug#6
Open
edgar-bonet wants to merge 5 commits intonrbrd:masterfrom
edgar-bonet:simplify-timer
Open
Timer: Cleanup and fix millis() rollover bug#6edgar-bonet wants to merge 5 commits intonrbrd:masterfrom edgar-bonet:simplify-timer
edgar-bonet wants to merge 5 commits intonrbrd:masterfrom
edgar-bonet:simplify-timer
Conversation
The three constructors have been replaced by a single one with default arguments. Timer::Create(), now redundant, has been removed.
Since the argument has an unsigned type, it cannot be negative.
Since unsigned numbers obey the rules of modular arithmetics, the usual rules of commutativity and associativity of addition apply.
There is no point in trying to detect a millis() rollover event as, per
the rules of modular arithmetics, the subtraction
millis() - LastTime
is rollover safe.
Fixes #4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request does some cleanup on the Timer module, removing code that has no effect other than making the source longer and harder to read. It also removes the lines intended to detect a
millis()rollover event:These lines are responsible from the issue #4. Besides, they serve no useful purpose, as the test that follows is rollover safe.