Skip to content

fix: ikea_bulb_device_set listener registration crash + ConfigEntryNotReady on connection failure #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pablotoledo wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix: ikea_bulb_device_set listener registration crash + ConfigEntryNotReady on connection failure #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion custom_components/dirigera_platform/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
import voluptuous as vol

from homeassistant import config_entries, core
from homeassistant.exceptions import ConfigEntryNotReady
import requests as _requests
from homeassistant.components.light import PLATFORM_SCHEMA
from homeassistant.const import CONF_IP_ADDRESS, CONF_TOKEN, Platform

Expand Down Expand Up @@ -195,7 +197,12 @@ async def async_setup_entry(
platform = ikea_gateway()
hass.data[DOMAIN][PLATFORM] = platform
logger.debug("Starting make_devices...")
await platform.make_devices(hass,hass_data[CONF_IP_ADDRESS], hass_data[CONF_TOKEN])
try:
await platform.make_devices(hass,hass_data[CONF_IP_ADDRESS], hass_data[CONF_TOKEN])
except (_requests.exceptions.ConnectionError, OSError) as err:
raise ConfigEntryNotReady(
f"Cannot connect to IKEA Dirigera hub at {hass_data[CONF_IP_ADDRESS]}: {err}"
) from err

#await hass.async_add_executor_job(platform.make_devices,hass, hass_data[CONF_IP_ADDRESS], hass_data[CONF_TOKEN])

Expand Down
2 changes: 1 addition & 1 deletion custom_components/dirigera_platform/light.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ def available(self):
def device_info(self) -> DeviceInfo:

# Register the device for updates
hub_event_listener.register(self.unique_id, self)
hub_event_listener.register(self.unique_id, registry_entry(self))

return DeviceInfo(
identifiers={("dirigera_platform", self._device_set.id)},
Expand Down