-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Improve C API support #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
925aac0 to
1adbb1b
Compare
ananos
approved these changes
Nov 4, 2025
Enable setting the C type for numeric type wrappers from the `CAny` adapter class. This allows functions that use `CAny`, instead of the type-specific `C*` classes, to specify the C types that will be used to represent numeric Python types. PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Update `Arg` with new C API; use new allocation/deallocation functions and implement arg type support PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Imlement `PluginType` enum for C enum `vaccel_plugin_type_t`, update `Session` class's `flags` type/methods and use the C heap allocation function PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Implement `*_from_buf()` for Python byte-like/numpy array objects and `*_sync` C operations in `Resource` class PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Set library path for tests from vAccel's pkg-config file instead of relying on the user to provide it PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Correctly access `vaccel_tf_node` C structure's ID in `tf.Node.id` method PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
1adbb1b to
5104cc7
Compare
papazof
added a commit
that referenced
this pull request
Nov 4, 2025
Enable setting the C type for numeric type wrappers from the `CAny` adapter class. This allows functions that use `CAny`, instead of the type-specific `C*` classes, to specify the C types that will be used to represent numeric Python types. PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
papazof
added a commit
that referenced
this pull request
Nov 4, 2025
Update `Arg` with new C API; use new allocation/deallocation functions and implement arg type support PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
papazof
added a commit
that referenced
this pull request
Nov 4, 2025
Imlement `PluginType` enum for C enum `vaccel_plugin_type_t`, update `Session` class's `flags` type/methods and use the C heap allocation function PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
papazof
added a commit
that referenced
this pull request
Nov 4, 2025
Implement `*_from_buf()` for Python byte-like/numpy array objects and `*_sync` C operations in `Resource` class PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
papazof
added a commit
that referenced
this pull request
Nov 4, 2025
Set library path for tests from vAccel's pkg-config file instead of relying on the user to provide it PR: #29 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve C API support and update
Argwith new interface:Argwith new C API and handle numeric types based on the specifiedArgTypePluginTypeandSessionflags*_from_buf()and*_syncC operations inResource