refactor: Remove custom resource cleanup #31
Merged
+12
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananos
approved these changes
Jan 7, 2026
Remove custom session handling for resource cleanup. Since nubificus/vaccel#193 introduced automatic resource unregistration upon release, there is no longer need for the bugprone extra bookkeeping/cleanup for registered resource sessions. PR: #31 Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
github-actions
bot
force-pushed
the
refactor_remove_custom_resource_cleanup
branch
from
f878d36 to
fe3e51c
Compare
Coverage report diff
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove custom session handling for resource cleanup. Since nubificus/vaccel#193 introduced automatic resource unregistration upon release, there is no longer need for the bugprone extra bookkeeping/cleanup for registered resource sessions.