Open
Conversation
|
I hope this pr will get some attention at least, there are open prs since 1 year so let's hope he does actually care for this one... |
Author
Absolutely. According to the author, he intends to actually merge these after the nightcore rewrite. The ExcellentCrates one is nearly perfect but has some flaws. This one should pretty much be done |
|
please pull |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folia was super straightforward for this plugin. I replaced the schedulers and that's it. That doesn't mean that this PR is necessarily "complete;" however, thus far, I have yet to encounter any odd or obscure issues. Feel free to test for yourself!