Open
Conversation
# Conflicts: # Core/pom.xml # Core/src/main/java/su/nightexpress/nexshop/api/shop/Shop.java # Core/src/main/java/su/nightexpress/nexshop/auction/AuctionManager.java # Core/src/main/java/su/nightexpress/nexshop/auction/config/AuctionConfig.java # Core/src/main/java/su/nightexpress/nexshop/auction/config/AuctionLang.java # Core/src/main/java/su/nightexpress/nexshop/auction/data/AuctionQueries.java # Core/src/main/java/su/nightexpress/nexshop/data/DataManager.java # Core/src/main/java/su/nightexpress/nexshop/dialog/AbstractDialogProvider.java # Core/src/main/java/su/nightexpress/nexshop/product/price/impl/FloatPricer.java # Core/src/main/java/su/nightexpress/nexshop/product/type/impl/PhysicalProductType.java # Core/src/main/java/su/nightexpress/nexshop/shop/chest/ChestShopModule.java # Core/src/main/java/su/nightexpress/nexshop/shop/chest/config/ChestPerms.java # Core/src/main/java/su/nightexpress/nexshop/shop/chest/menu/PriceMenu.java # Core/src/main/java/su/nightexpress/nexshop/shop/chest/menu/ProductsMenu.java # Core/src/main/java/su/nightexpress/nexshop/shop/impl/AbstractProduct.java # Core/src/main/java/su/nightexpress/nexshop/shop/menu/ProductPriceMenu.java # Core/src/main/java/su/nightexpress/nexshop/shop/virtual/ShopCreator.java # Core/src/main/java/su/nightexpress/nexshop/shop/virtual/VirtualShopModule.java # Core/src/main/java/su/nightexpress/nexshop/shop/virtual/editor/rotation/RotationItemSelectMenu.java # Core/src/main/java/su/nightexpress/nexshop/shop/virtual/lang/VirtualLang.java # Core/src/main/java/su/nightexpress/nexshop/shop/virtual/menu/SellMenu.java # Core/src/main/resources/plugin.yml # pom.xml
# Conflicts: # Core/src/main/java/su/nightexpress/nexshop/shop/menu/ProductPriceMenu.java # Core/src/main/java/su/nightexpress/nexshop/shop/virtual/editor/product/ProductStocksMenu.java # Core/src/main/java/su/nightexpress/nexshop/shop/virtual/editor/rotation/RotationOptionsMenu.java
|
Can't wait to try it on folia |
ColdTearsYY
approved these changes
Dec 1, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ColdTearsYY
added a commit
to ColdTearsYY/ExcellentShop-folia
that referenced
this pull request
Dec 1, 2025
- Fix runTaskAsync lambda parameter types (use task -> instead of () ->) - Fix runTask method reference ambiguity with explicit lambdas - Update Confirmation class to delegate to nightcore's Confirmation - Remove deprecated ConfirmMenu (no longer used) - Fix player variable reference in PlayerShopDialogs - Update Confirmation imports to use nightcore's version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin appears to work with the changes below fully. I have removed various dependencies temporarily to ensure that I can thoroughly test the plugin. I replicated said dependencies locally to ensure they still work with Folia and can be reimplemented for the final iteration of this plugin, once more.