feat(src): add cr-pin attribute to control#60
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- dev/index.html: Language not supported
Comments suppressed due to low confidence (1)
src/modal/modal.ts:164
- Resetting the _crPin property unconditionally may override custom settings provided via updateModalOptions. Consider preserving the crPin state if it has been explicitly set.
this._crPin = Constant.crPin.on;
Ref: #58 Introduce cr-pin attribute to control CR Pin behavior.
olgahaha
force-pushed
the
feature-attribute-cr-pin
branch
from
413c184 to
fa1a300
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #58
Added