Skip to content

Comments

Auto-fix linting and remove line length linting#1020

Merged
SeanKilleen merged 3 commits intomasterfrom
linting-improvements
Feb 10, 2025
Merged

Auto-fix linting and remove line length linting#1020
SeanKilleen merged 3 commits intomasterfrom
linting-improvements

Conversation

@SeanKilleen
Copy link
Member

@SeanKilleen SeanKilleen commented Feb 10, 2025

After a quick conversation with @OsirisTerje we agreed that 1) it would be helpful to auto-fix markdownlint issues in docs on save, and 2) we didn't want the line length to cause issues in linting.

So, this PR:

  • Adds the auto-fix on save functionality for Codespaces (and puts the same in the readme)
  • Removes the line length linting
  • Leaves the Rewrap plugin so that we can still have some friendly help on line length when desired
  • Leaves "editor.rulers": [120] in settings so that we have a visual guideline.

Closes #887

@SeanKilleen SeanKilleen changed the title Auto-fix linting and remove line length requirements Auto-fix linting and remove line length linting Feb 10, 2025
@github-actions
Copy link

@SeanKilleen SeanKilleen merged commit 4325c7d into master Feb 10, 2025
7 checks passed
@SeanKilleen SeanKilleen deleted the linting-improvements branch February 10, 2025 19:08
@SeanKilleen
Copy link
Member Author

CC @OsirisTerje , this is in the main branch now. :)

github-actions bot pushed a commit that referenced this pull request Feb 10, 2025
* auto-fix markdownlint issues on save

* Add to README

* remove line size from markdown linting 4325c7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Action update to do an auto-fix for markdown linting

1 participant