Skip to content

Fixed the failing tests, which failed due to our deprecation of TimeOut #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OsirisTerje merged 2 commits into from
Feb 18, 2026
Merged

Fixed the failing tests, which failed due to our deprecation of TimeOut #1136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
983420b
Fixed the failing tests, which failed due to our deprecation of TimeOut
OsirisTerje Feb 18, 2026
ebb0884
fixed yml
OsirisTerje Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-process.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
name: "Build/Test Snippets"
runs-on: ubuntu-latest
env:
SOLUTION_LOCATION: "./docs/snippets/Snippets.sln"
SOLUTION_LOCATION: "./docs/snippets/Snippets.slnx"
steps:
- name: Check out the code
uses: actions/checkout@v6
Expand Down
4 changes: 3 additions & 1 deletion docs/snippets/Snippets.NUnit/AttributeExamples.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,11 @@ public void AnotherManualTest()
}
}

[Explicit("This code doesnt work on net, only netframework")]
[TestFixture]
public class TimeoutAttributeExamples
{
#pragma warning disable CS0618 // Type or member is obsolete
#pragma warning disable CS0618 // Type or member is obsolete[Explicit("This doesnt work on .net, only .netframework")]
#region TimeoutExample
[Test]
[Timeout(1000)] // 1 second timeout
Expand All @@ -257,6 +258,7 @@ public void FastTest()
#pragma warning restore CS0618 // Type or member is obsolete

#pragma warning disable CS0618 // Type or member is obsolete

#region TimeoutWithAsyncExample
[Test]
[Timeout(2000)] // 2 second timeout
Expand Down
2 changes: 1 addition & 1 deletion docs/snippets/Snippets.NUnit/Snippets.NUnit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="NUnit" Version="4.5.0-alpha.0.33" />
<PackageReference Include="NUnit" Version="4.5.0" />
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
<PackageReference Include="NUnit.Analyzers" Version="4.11.2">
<PrivateAssets>all</PrivateAssets>
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/Snippets.NUnitLite/Snippets.NUnitLite.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="NUnit" Version="4.4.0" />
<PackageReference Include="NUnit" Version="4.5.0" />
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
<PackageReference Include="NUnit.Analyzers" Version="4.11.2">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="8.0.0" />
<PackageReference Include="NUnitLite" Version="4.4.0" />
<PackageReference Include="NUnitLite" Version="4.5.0" />
</ItemGroup>

</Project>
37 changes: 0 additions & 37 deletions docs/snippets/Snippets.sln
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions docs/snippets/Snippets.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<Solution>
<Folder Name="/Solution Items/">
<File Path="naming.runsettings" />
<File Path="nuget.config" />
</Folder>
<Project Path="Snippets.NUnit/Snippets.NUnit.csproj" />
<Project Path="Snippets.NUnitLite/Snippets.NUnitLite.csproj" />
</Solution>