Improve CPU performance by using json-iterator instead of encoding/json#12
Open
debnath wants to merge 3 commits intonvellon:masterfrom
Open
Improve CPU performance by using json-iterator instead of encoding/json#12debnath wants to merge 3 commits intonvellon:masterfrom
debnath wants to merge 3 commits intonvellon:masterfrom
Conversation
Author
|
Looks like the travisci check has failed due to not being to import in package Please go ahead and delete this PR if you wanted to retain go1.4 compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, not sure if you wanted to add in vendor'd dependencies into your package, but figured I'll open a PR and see if you wanted the change.
I noticed while running
pprofon my production application that the json Unmarshalling of packagenvellon/halwas in the top5 CPU consuming functions. So I swapped outencoding/jsonwithjson-iteratoron my fork and noticed an immediate improvement in both CPU consumption as well as latency.I also noticed the unit tests fail in go1.12, so I made some minor changes to the tests.