Skip to content

Conversation

@jasukej
Copy link
Contributor

@jasukej jasukej commented Jan 12, 2026

Reason

  • after syncing w erping + engagement reqs: stamps should be hackathon-specific (also makes url generation more consistent as we can directly sub in hackathon slug)
  • delete QR if isQRUnlockable toggled off
  • allow admin to add locked image state (what the hacker sees before the stamp is unlocked)

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

Visit the preview URL for this PR (updated for commit 2ab4702):

https://dev-nwplus-admin--pr91-fix-stampbook-x8uhu9k8.web.app

(expires Fri, 23 Jan 2026 09:13:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c290bf9e2fac0401389f751f415cce4267517b51

@jasukej jasukej changed the title fix: remove global designation + qr deletion for stamps fix: add locked image state + qr deletion + other misc fixes Jan 13, 2026
Comment on lines +201 to +204

setLockedImageFile(null);
setLockedImagePreview(null);
setLockedImageError(null);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lowkey just copied over image select, as of right now don't think it's worth refactoring to its own component

@tdanielles
Copy link
Contributor

functionality lgtm i think tyyyy! one thing i wanna confirm is it looks like on stamp creation only the stamp image is required but the locked image is optional. is it the case that if no one uploads anything there it would default to the locked one we have now?? just wanted to make sure it doesnt error / glitch out or anything if that happens on portal side

@jasukej
Copy link
Contributor Author

jasukej commented Jan 13, 2026

functionality lgtm i think tyyyy! one thing i wanna confirm is it looks like on stamp creation only the stamp image is required but the locked image is optional. is it the case that if no one uploads anything there it would default to the locked one we have now?? just wanted to make sure it doesnt error / glitch out or anything if that happens on portal side

Yep on portal it will default to the one we have rn, kept it as optional for now as we backfill the stamps.

Until I merge this PR on portal it won't use the locked stamps image put I can push that change to dev separately if needed: nwplus/portal-v2#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants