drivers: usb: lan78xx: add support to control LED mode register#11
Open
teslafields wants to merge 1 commit intonxp-imx:lf-6.1.yfrom
Open
drivers: usb: lan78xx: add support to control LED mode register#11teslafields wants to merge 1 commit intonxp-imx:lf-6.1.yfrom
teslafields wants to merge 1 commit intonxp-imx:lf-6.1.yfrom
Conversation
Contributor
Your changes only touch things in drivers/net so I'm pretty sure this is stuff for the netdev mailing list. See these pages in the Linux kernel documentation: |
Overdr0ne
pushed a commit
to Overdr0ne/linux-imx
that referenced
this pull request
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not really sure if this is the right place to suggest this contribution, but I don't know where else to do it.
Currently, the
lan78xxdriver is checking if"microchip,led-modes"property was set in the devicetree, then it only enables the LEDs by writing to theHW_CFGregister. This however is not enough, as the property, when set, contains the value of each defined LED, and so it's necessary to read these values and write to the PHY LED Mode register accordingly.Following the documentation (Documentation/devicetree/bindings/net/microchip,lan78xx.txt):