Add radarr config option for setting minimum availability#149
Add radarr config option for setting minimum availability#149AhmedNSidd wants to merge 2 commits intonylonee:mainfrom
Conversation
|
Warning Rate limit exceeded@nylonee has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 35 minutes and 46 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis set of updates introduces a new configuration field Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
src/main/resources/config-template.yamlis excluded by!**/*.yaml
Files selected for processing (6)
- src/main/scala/configuration/Configuration.scala (1 hunks)
- src/main/scala/configuration/ConfigurationRedactor.scala (1 hunks)
- src/main/scala/configuration/ConfigurationUtils.scala (2 hunks)
- src/main/scala/configuration/Keys.scala (1 hunks)
- src/main/scala/radarr/RadarrPost.scala (1 hunks)
- src/main/scala/radarr/RadarrUtils.scala (1 hunks)
Additional comments not posted (6)
src/main/scala/radarr/RadarrPost.scala (1)
8-8: The addition ofminimumAvailabilitytoRadarrPostaligns well with the new feature requirements.src/main/scala/configuration/Configuration.scala (1)
31-31: The addition ofradarrMinimumAvailabilitytoRadarrConfigurationis correctly implemented and necessary for the new feature.src/main/scala/configuration/Keys.scala (1)
18-18: The addition of theradarrMinimumAvailabilitykey is correctly implemented and aligns with the new feature requirements.src/main/scala/configuration/ConfigurationRedactor.scala (1)
23-23: The inclusion ofradarrMinimumAvailabilityin the configuration output is correctly implemented and enhances transparency and debuggability.src/main/scala/radarr/RadarrUtils.scala (1)
38-38: The update to includeradarrMinimumAvailabilityin theaddToRadarrmethod is correctly implemented and necessary for the new feature to function as intended.src/main/scala/configuration/ConfigurationUtils.scala (1)
Line range hint
38-68: The update to includeradarrMinimumAvailabilityin thecreatemethod is correctly implemented and necessary for the new feature to function as intended.
|
Just built the docker image from this PR and ran it on my personal media server, then added something to the watchlist and confirmed that the As expected, it changed the minimumAvailability in Radarr for that movie. |
nylonee
left a comment
There was a problem hiding this comment.
Sorry it took me a while to get to this - looks good, the tests are failing to compile though, could you update the tests?
|
Would be nice to have this feature. |
|
Sorry about opening this and then just leaving it. A lot of work responsibilities / personal responsibilities came up and then this fell off my radar. I'll try to take a look at this soon, maybe over the weekend. |
Description
I was noticing that some movies that my family added to the Plex Watchlist weren't being downloaded automatically. Upon further investigation, this was because they had not been fully released, and instead were just released in cinemas. Currently Overseerr offers a configuration option for setting a minimum availability for media requests in Radarr, so I thought it'd be appropriate to have an option for this in Watchlistarr as well.
Checklist
sbt scalafmtAllRun (and optionallysbt scalafmtSbt)