Skip to content

Conversation

@bertpareyn
Copy link
Contributor

There is scrollbar within a scrollbar currently in Chrome on the manage access pane. This doesn't seem to happen in firefox.

In the attached screenshot, notice how much further I am able to scroll the outer container that holds the members container.

To reproduce, create a content item with a number of members that stretches outside the scroll range of the inner container.

screen shot 2013-07-18 at 12 27 20 pm

@ghost ghost assigned bertpareyn Jul 18, 2013
@mrvisser
Copy link
Contributor Author

Assigned to @BP323 as I am likely stuck on Tsung work for the remainder of the current sprint.

@bertpareyn
Copy link
Contributor

Hmm I've seen this before when uploading a bunch of content in the upload widget. The inner container is doing something weird I think.

@bertpareyn
Copy link
Contributor

Hmm it looks like the upload widget also suffers from this. Investigating.

@ghost ghost assigned mrvisser Aug 7, 2013
@bertpareyn
Copy link
Contributor

Reassigning for review.

@ghost ghost assigned nicolaasmatthijs Aug 7, 2013
@nicolaasmatthijs
Copy link
Contributor

We can't really do this as the modal-body has a maximum height and the scrollbar is a final fallback to make sure that all modal content is shown. For example, when viewing the My Profile overlay in French, you'll see that the content is slightly higher than the max height. In current master, a scrollbar will be shown, which is not ideal but doesn't break anything. However, with this patch that is cut off and no longer visible.

Given that we're trying to provide a development for students, we can probably not enforce this max height without offering a scrollbar.

Assigning back to @BP323 for further investigation.

@ghost ghost assigned bertpareyn Aug 13, 2013
@bertpareyn
Copy link
Contributor

This might be addressed by the Bootstrap upgrade at #3178

@ghost ghost assigned nicolaasmatthijs Sep 9, 2013
@nicolaasmatthijs
Copy link
Contributor

#3178 is now in follow-up

@ghost ghost assigned bertpareyn Sep 19, 2013
@ghost ghost assigned nicolaasmatthijs Oct 7, 2013
@nicolaasmatthijs
Copy link
Contributor

Moving out of 3.0.0

@nicolaasmatthijs
Copy link
Contributor

Tracking in #3178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants