-
Notifications
You must be signed in to change notification settings - Fork 202
Manage Access scrollbar inception on Chrome #3115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigned to @BP323 as I am likely stuck on Tsung work for the remainder of the current sprint. |
|
Hmm I've seen this before when uploading a bunch of content in the upload widget. The inner container is doing something weird I think. |
|
Hmm it looks like the upload widget also suffers from this. Investigating. |
|
Reassigning for review. |
|
We can't really do this as the modal-body has a maximum height and the scrollbar is a final fallback to make sure that all modal content is shown. For example, when viewing the My Profile overlay in French, you'll see that the content is slightly higher than the max height. In current master, a scrollbar will be shown, which is not ideal but doesn't break anything. However, with this patch that is cut off and no longer visible. Given that we're trying to provide a development for students, we can probably not enforce this max height without offering a scrollbar. Assigning back to @BP323 for further investigation. |
|
This might be addressed by the Bootstrap upgrade at #3178 |
|
#3178 is now in follow-up |
|
Moving out of 3.0.0 |
|
Tracking in #3178 |
There is scrollbar within a scrollbar currently in Chrome on the manage access pane. This doesn't seem to happen in firefox.
In the attached screenshot, notice how much further I am able to scroll the outer container that holds the members container.
To reproduce, create a content item with a number of members that stretches outside the scroll range of the inner container.