Skip to content

Add LLVM Support#93

Merged
obelisk merged 30 commits intomainfrom
add_llvm
Apr 4, 2025
Merged

Add LLVM Support#93
obelisk merged 30 commits intomainfrom
add_llvm

Conversation

@obelisk
Copy link
Owner

@obelisk obelisk commented Apr 1, 2025

Maybe LLVM is super fast comparatively. I don't know but I do know I want to find out.

@obelisk obelisk force-pushed the add_llvm branch 8 times, most recently from 97dab79 to 5eab7a7 Compare April 1, 2025 21:47
@obelisk
Copy link
Owner Author

obelisk commented Apr 1, 2025

Getting it to build on macOS was a bit of a challenge. Eventually this is what worked: RUST_LOG=debug RUSTFLAGS="-L /opt/homebrew/lib/" LLVM_SYS_180_PREFIX=/opt/homebrew/Cellar/llvm@18/18.1.8 cargo run --release --no-default-features --features=llvm,sled --bin=plaid -- --config plaid/resources/plaid.toml --secrets plaid/resources/secrets.example.json

@obelisk obelisk force-pushed the add_llvm branch 2 times, most recently from 291473b to 129be44 Compare April 3, 2025 07:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • modules/Makefile: Language not supported
  • modules/tests/test_regex/harness/harness.sh: Language not supported
  • runtime/plaid/resources/docker/Dockerfile: Language not supported
  • runtime/plaid/resources/docker/musl/Dockerfile.aarch64: Language not supported
  • runtime/plaid/resources/docker/musl/Dockerfile.amd64: Language not supported
  • testing/integration.sh: Language not supported
Comments suppressed due to low confidence (1)

modules/tests/test_regex/src/lib.rs:17

  • The test does not include an assertion to validate the regex match result; consider adding an assertion to verify that the regex behavior matches the expected outcome.
let is_match = regex.is_match(&log);

@obelisk obelisk merged commit 4c4b5a1 into main Apr 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants