Conversation
97dab79 to
5eab7a7
Compare
Owner
Author
|
Getting it to build on macOS was a bit of a challenge. Eventually this is what worked: |
291473b to
129be44
Compare
There was a problem hiding this comment.
Copilot reviewed 16 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (6)
- modules/Makefile: Language not supported
- modules/tests/test_regex/harness/harness.sh: Language not supported
- runtime/plaid/resources/docker/Dockerfile: Language not supported
- runtime/plaid/resources/docker/musl/Dockerfile.aarch64: Language not supported
- runtime/plaid/resources/docker/musl/Dockerfile.amd64: Language not supported
- testing/integration.sh: Language not supported
Comments suppressed due to low confidence (1)
modules/tests/test_regex/src/lib.rs:17
- The test does not include an assertion to validate the regex match result; consider adding an assertion to verify that the regex behavior matches the expected outcome.
let is_match = regex.is_match(&log);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe LLVM is super fast comparatively. I don't know but I do know I want to find out.