Skip to content

Comments

Showing reference and current images along with the diff result#311

Draft
Muritavo wants to merge 2 commits intooblador:masterfrom
Muritavo:feature/diffWithReference
Draft

Showing reference and current images along with the diff result#311
Muritavo wants to merge 2 commits intooblador:masterfrom
Muritavo:feature/diffWithReference

Conversation

@Muritavo
Copy link

@Muritavo Muritavo commented Mar 1, 2021

This PR enables a feature requested by #144 as it's useful for when comparing complex UI changes.

What does it change:

  • Added a new property called includeReferenceOnDiff (default: false)
  • When the property is enabled, the reference image and the current images are concatenated side by side along with the diff result.

Currently is set as draft because it needs the following adjustments:

Make the property work on the other two diff engines, if someone want to do it, fell free to contribute to this PR as well

@Muritavo Muritavo changed the title Feature/diff with reference Showing reference and current images along with the diff result Mar 1, 2021
@Muritavo
Copy link
Author

Muritavo commented Mar 1, 2021

Adding here so it is documented:

For the GraphicsMagick library there is a method montage, that combines multiple images side by side.

As for the looks-same library, the createDiff without diff property can be used to manually write the file to disk, with the other references

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant