fix(skills): fix the regexp in the update_docs.js script#4
fix(skills): fix the regexp in the update_docs.js script#4
Conversation
Evidently they changed the URL scheme in [llms.txt](https://docs.claude.com/llms.txt) has changed; `claude-code` is no longer in the URL. After this change, the script fetches 95 docs.
WalkthroughThe regex pattern in the documentation update script was modified to broaden URL matching from specifically Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
skills/working-with-claude-code/scripts/update_docs.js (1)
17-17: Consider updating names and comments to reflect the broader scope.While the regex fix is correct, the constant name
CLAUDE_CODE_PATTERN, function namegetClaudeCodeUrls(), and various comments (lines 6, 40, 85, 87) still reference "Claude Code" specifically. Since the pattern now matches all documentation under/en/docs/, consider renaming to better reflect this broader scope (e.g.,DOCS_PATTERN,getDocsUrls()).Also applies to: 42-42
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
skills/working-with-claude-code/scripts/update_docs.js(1 hunks)
🔇 Additional comments (1)
skills/working-with-claude-code/scripts/update_docs.js (1)
17-17: LGTM! The regex fix correctly addresses the URL scheme change.The updated pattern successfully broadens the match criteria from specifically
/claude-code/subdirectories to any path under/en/docs/, which resolves the zero-file download issue.
Fixed the regexp in
update_docs.jsscript.Motivation and Context
This script was downloading 0 files.
Evidently they changed the URL scheme in llms.txt has changed;
claude-codeis no longer in the URL.After this change, the script fetches 95 docs.
How Has This Been Tested?
Manually
Breaking Changes
No
Types of changes
Checklist
Additional context
Summary by CodeRabbit