Skip to content

Conversation

@exeldro
Copy link
Contributor

@exeldro exeldro commented Dec 27, 2025

Description

Add missing file support for filters

Motivation and Context

When importing a scene collection you get a popup with missing files which does not contain all missing files.

How Has This Been Tested?

On windows 11 with a mask filter and remove the mask from disk

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@exeldro exeldro force-pushed the filter_missing_files branch from c17aa4a to cfc8db6 Compare December 27, 2025 11:52
@Warchamp7 Warchamp7 added the UI/UX Anything to do with changes or additions to UI/UX elements. label Dec 27, 2025
@Warchamp7 Warchamp7 self-assigned this Dec 27, 2025
@Warchamp7 Warchamp7 self-requested a review December 27, 2025 12:15
Copy link
Member

@PatTheMav PatTheMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine apart from code style changes.

It feels a bit "wrong" having to implement this frontend concern in the filters themselves (instead the frontend should be able to look at the "resources" used by a source and thus check for its existence), but this is how the system currently works in OBS for better or worse.

@exeldro exeldro force-pushed the filter_missing_files branch from cfc8db6 to 0b8b657 Compare January 15, 2026 07:25
@exeldro
Copy link
Contributor Author

exeldro commented Jan 15, 2026

Rebased and applied suggestions from @PatTheMav

@exeldro exeldro force-pushed the filter_missing_files branch from 0b8b657 to df95dba Compare January 16, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI/UX Anything to do with changes or additions to UI/UX elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants