-
-
Notifications
You must be signed in to change notification settings - Fork 9k
Potential 27.2 backports #6399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential 27.2 backports #6399
Conversation
The old behavior toggled display affinity every time the window was updated instead of applying it consistently.
The pointer has been freed by this point so it just segfaults. Signed-off-by: Joshua Ashton <joshua@froggi.es>
Verbosity of stdout was previously hardcoded to INFO, while log viewer and log files had correct verbosity. This makes the behavior of --verbose make sense in all places.
|
libobs-opengl: Use gl helpers in create_dmabuf_image is already requested in another backport PR. |
|
I intentionally added it here as well. |
|
I personally need a lot of convincing to change dependencies in patch/bugfix releases. |
That's a fair point. My reasoning (at least for obsdeps/102) would be "the earlier we can fix the broken docks the better, because as it is they're just unusable". The other ones aren't that important, we can probably ignore them. |
|
@gxalpha Please drop the merged commit of dmabuf changes and we'll merge this. |
If the user would minimize to tray instead of taskbar, the window would flash when clicking show in the tray menu, and the preview would be disabled. This would only happen on Linux.
This removes the min and max size properties from the YouTube "Manage Broadcast" dialog. Such values depend on the actual content or very precise layout management, making hardcoded values prone to being incorrect. To avoid incorrect values we should avoid these settings on top level widgets/windows. This pattern can lead to crashes on Wayland compositors like GNOME which are strict about these values being correct.
c89d8d6 to
51a0887
Compare
|
done |
|
Going to close this since it's not looking like a 27.2.5 is likely right now. |
|
That was a good idea, I'm writing my own backport because the new 28.0 beta 1 brings too many new features too fresh to be integrated in production. |
Description
Should (and that's an if, not a when) a 27.2.5 happen, these are the fixes I'd propose for backporting from master.
Includes some smaller fixes (like with the display affinity) and crashes (mainly on Linux).
obs-deps#102 should definitely also be included should it get merged, imo.
Motivation and Context
There was some discussion about a potential 27.2.5 recently. While it's not given that such a release will happen, having everything ready to go in the release branch makes sense.
I also think that in the future we should cherry-pick changes into the release-branch immediately after merging a PR into master (if a PR is a crash fix or simple bug fix and considered to be worthy of being included in a patch release), that way we won't have to go through the history later.
How Has This Been Tested?
The changes have of course all been tested in their respective PRs, but this as a whole has not yet been tested.
Needs testing with CI artifacts.
Types of changes
Checklist:
This PR includes #6376.