Skip to content

Conversation

@gxalpha
Copy link
Member

@gxalpha gxalpha commented Apr 30, 2022

Description

Should (and that's an if, not a when) a 27.2.5 happen, these are the fixes I'd propose for backporting from master.
Includes some smaller fixes (like with the display affinity) and crashes (mainly on Linux).

obs-deps#102 should definitely also be included should it get merged, imo.

Motivation and Context

There was some discussion about a potential 27.2.5 recently. While it's not given that such a release will happen, having everything ready to go in the release branch makes sense.

I also think that in the future we should cherry-pick changes into the release-branch immediately after merging a PR into master (if a PR is a crash fix or simple bug fix and considered to be worthy of being included in a patch release), that way we won't have to go through the history later.

How Has This Been Tested?

The changes have of course all been tested in their respective PRs, but this as a whole has not yet been tested.
Needs testing with CI artifacts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

This PR includes #6376.

notr1ch and others added 5 commits April 30, 2022 12:42
The old behavior toggled display affinity every time the window was
updated instead of applying it consistently.
The pointer has been freed by this point so it just segfaults.

Signed-off-by: Joshua Ashton <joshua@froggi.es>
Verbosity of stdout was previously hardcoded to INFO, while log viewer
and log files had correct verbosity. This makes the behavior of
--verbose make sense in all places.
@gxalpha gxalpha added the Seeking Testers Build artifacts on CI label Apr 30, 2022
@kkartaltepe
Copy link
Collaborator

libobs-opengl: Use gl helpers in create_dmabuf_image is already requested in another backport PR.

@gxalpha
Copy link
Member Author

gxalpha commented Apr 30, 2022

I intentionally added it here as well.
As I alluded to in the PR description, I'm personally not a big fan of having any backport PRs in general, let alone multiple (which is why I also added it to this PR) - they might get buried amongst the other PRs, changes aren't in the same order as on master, and if we merge some but not others there's a chance we'll lose track of which changes were already considered and which weren't etc.
Though if we think having multiple backport PRs is fine, I guess I could remove it here.

@RytoEX
Copy link
Member

RytoEX commented Apr 30, 2022

I personally need a lot of convincing to change dependencies in patch/bugfix releases.

@gxalpha
Copy link
Member Author

gxalpha commented Apr 30, 2022

I personally need a lot of convincing to change dependencies in patch/bugfix releases.

That's a fair point. My reasoning (at least for obsdeps/102) would be "the earlier we can fix the broken docks the better, because as it is they're just unusable". The other ones aren't that important, we can probably ignore them.

@WizardCM
Copy link
Member

@gxalpha Please drop the merged commit of dmabuf changes and we'll merge this.

mvji and others added 3 commits May 1, 2022 09:45
If the user would minimize to tray instead of taskbar, the
window would flash when clicking show in the tray menu, and
the preview would be disabled. This would only happen on Linux.
This removes the min and max size properties from the YouTube "Manage
Broadcast" dialog. Such values depend on the actual content or very
precise layout management, making hardcoded values prone to being
incorrect. To avoid incorrect values we should avoid these settings on
top level widgets/windows.

This pattern can lead to crashes on Wayland compositors like
GNOME which are strict about these values being correct.
@gxalpha gxalpha force-pushed the twentyseven-dot-two-dot-five-backports branch from c89d8d6 to 51a0887 Compare May 1, 2022 07:46
@gxalpha
Copy link
Member Author

gxalpha commented May 1, 2022

done

@tt2468
Copy link
Member

tt2468 commented Jun 26, 2022

Going to close this since it's not looking like a 27.2.5 is likely right now.

@tt2468 tt2468 closed this Jun 26, 2022
@gxalpha gxalpha deleted the twentyseven-dot-two-dot-five-backports branch July 8, 2022 16:04
@ogmkp
Copy link

ogmkp commented Aug 3, 2022

That was a good idea, I'm writing my own backport because the new 28.0 beta 1 brings too many new features too fresh to be integrated in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Seeking Testers Build artifacts on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.