Add Flatpak aarch64 builds #8105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tytan652
commented
Jan 21, 2023
.github/workflows/flatpak.yml
Outdated
Comment on lines
-94
to
+169
| ostree commit --repo=repo --canonical-permissions --branch=screenshots/x86_64 flatpak_app/screenshots | ||
| ostree commit --repo=repo --canonical-permissions --branch=screenshots/${{ matrix.arch }} flatpak_app/screenshots |
.github/workflows/main.yml
Outdated
Comment on lines
85
to
78
| if test -n "$(curl -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" -s "${{ github.event.pull_request.url }}" | jq -e '.labels[] | select(.name == "Flatpak aarch64")')"; then | ||
| echo 'flatpak_matrix=["x86_64", "aarch64"]' >> $GITHUB_OUTPUT | ||
| else | ||
| echo 'flatpak_matrix=["x86_64"]' >> $GITHUB_OUTPUT | ||
| fi |
Collaborator
Author
There was a problem hiding this comment.
Is Flatpak aarch64 a good label name to enable aarch64 build on PRs ?
tytan652
force-pushed
the
flatpak_aarch64
branch
from
baf2266 to
4930b39
Compare
tytan652
force-pushed
the
flatpak_aarch64
branch
from
4930b39 to
d3c4cb7
Compare
tytan652
force-pushed
the
flatpak_aarch64
branch
2 times, most recently
from
4a5b354 to
8610b91
Compare
Collaborator
Author
|
NOTE for self: add an option to the upstream action to use flatpak-builder option |
tytan652
force-pushed
the
flatpak_aarch64
branch
2 times, most recently
from
ffec62e to
52fdeb2
Compare
Collaborator
Author
|
Drafted waiting for PRs on flatpak action being reviewed and merged. |
tytan652
force-pushed
the
flatpak_aarch64
branch
5 times, most recently
from
196206e to
d0c10e9
Compare
tytan652
force-pushed
the
flatpak_aarch64
branch
3 times, most recently
from
6a4e7d1 to
20b7fff
Compare
tytan652
force-pushed
the
flatpak_aarch64
branch
from
20b7fff to
c8124ee
Compare
Contributor
SVT-AV1 builds on AArch64 just fine. We build it in Fedora for all architectures. |
Collaborator
Author
When the PR was made, SVT-AV1 repo was explicitly stating that only x86_64 was supported, it has indeed changed since then. Note, that PR is under a heavy rewrite. |
Collaborator
Author
|
Closed over #9979 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on:
Add aarch64 to the manifest:
Disable SVT-AV1 on non-x86_64 and add CEF arm64, both setup with shell commands to avoid duplicating modules.
Add aarch64 to CIs:
Building through QEMU emulation is really slow. So to avoid timing out
the job (6h), the original job is split in two.
The first job build dependencies (4-5h), if the cache already exist the
build is skipped.
And the second job build CEF and OBS Studio by relying on the cache of the
first job (2-3h).
This separation is done by modifying the manifest in the first job to
build only dependencies with a fake "obs" module/command.
aarch64 builds are not enabled by default on the main workflow, it can
be enabled with a dedicated label on PRs.
Motivation and Context
Publish Flatpak aarch64 builds.
How Has This Been Tested?
CI with a PR on my fork: tytan652#8 (aarch64 artifacts availlable)
Types of changes
Checklist: