-
-
Notifications
You must be signed in to change notification settings - Fork 9k
Add WebRTC Simulcast Support #9165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8f0dcbd to
0ddea45
Compare
|
I started to review this but it seems like this is still at the proof of concept stage, there are too many hard coded assumptions and the deps point to your own repo. I don't think this was ready to be PR'ed. |
|
Hey @notr1ch appreciate the review! I put the PR up to get feedback about the right way to do this. Instead of hardcoding these values what do you think would be best for users?
|
1641633 to
9cccd77
Compare
|
Those kinds of questions are best answered by creating an RFC. While this looks like a promising POC, it's way too early to be opened as a pull request. |
|
@notr1ch I have multiple companies testing this PR. Can you please re-open so I can continue collaborating with people on this highly requested feature. We also will not need a RFC. The developers of this PR discussed internally and will be doing a UI. Simulcast will not be available under simple at first. What are the rules/requirements for a draft PR. Can you please provide the official guidelines |
|
Guidelines for when an RFC is appropriate can be found on the RFC repo in the readme: |
|
@Fenrirthviti @notr1ch RFC is here Can you please re-open this PR now? It seems to be an accepted pattern to have a example implementation. here and here |
|
That kind of pattern isn't exactly accepted, it's just happened. Discussion can take place on the RFC, and collaboration on the implementation can take place on your fork if there is still implementation work to be done. It would likely also be best to wait until the RFC is in a state that the project agrees on first, to avoid unnecessary efforts. I'd prefer that this remain closed until it's ready for actual review to avoid cluttering the repo. Previous PRs in this ecosystem had a lot of troubleshooting and off-topic chatter that I'd like to avoid as well, as it complicated review having to sift through what were effectively support questions, not development questions. |
Description
WebRTC allows broadcasters to upload multiple streams of different quality. OBS users could upload ‘high’, ‘med’, and ‘low’ streams themselves.
Motivation and Context
How Has This Been Tested?
Tested against https://github.com/glimesh/broadcast-box
Types of changes
Checklist: