Skip to content

lowercase opam where appropriate#252

Open
hannesm wants to merge 1 commit intoocaml-opam:masterfrom
hannesm:opam-not-OPAM
Open

lowercase opam where appropriate#252
hannesm wants to merge 1 commit intoocaml-opam:masterfrom
hannesm:opam-not-OPAM

Conversation

@hannesm
Copy link
Contributor

@hannesm hannesm commented Jan 15, 2026

the only letfover OPAM are not in code (OpamFile.OPAM), and in the submodule pointing to the ocaml/opam wiki -- which I can change as well if you like (it is here content/doc). Since I don't know of how to PR to wikis, please fine attached a patch for the wiki, feel free to review and push.

wiki.diff.patch

@kit-ty-kate
Copy link
Member

Thanks for the PR. For the "wiki" though, i'm a bit confused as to what is being patched here. I've tried to apply it to https://github.com/ocaml/opam.wiki.git and ocaml/opam:doc/pages but either the patch failed or the files being patched do not exist.

@hannesm
Copy link
Contributor Author

hannesm commented Jan 15, 2026

Interesting, so what I did was a git submodules init --update in this repository on my local checkout, and then these files appeared on content/doc (at rev .13a77b2bc576763bfa469ca3ef6f139402b7357b from Mon Aug 18 07:22:19 2014 -0700). I've not much knowledge about the submodules stuff, neither how the opam page is made. If it is not online, let's ignore it. Maybe the submodule can be removed?

@kit-ty-kate
Copy link
Member

(at rev .13a77b2bc576763bfa469ca3ef6f139402b7357b from Mon Aug 18 07:22:19 2014 -0700)

oh i see, it's an old documentation from opam 1.1, no wonder it failed to apply on the latest commit :D
I'm not too sure why this is a submodule of a wiki instead of a simple copy. We should probably change that

@rjbou
Copy link
Contributor

rjbou commented Jan 15, 2026

In fact, opam 1.1 and 1.2 was written capitalized OPAM. It changed during 2.0 release (cf ocaml/opam@63e9bc2). So it makes sense imo to keep 1.1 and 1.2 doc with OPAM.

@rjbou
Copy link
Contributor

rjbou commented Feb 2, 2026

Discussed in dev meeting (01/19/2026): As it is legacy, it should be kept as OPAM (the name of the tool at that time/releases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants