this arange does not get max k endpoint, change to linsapce#23
Open
dhidas wants to merge 1 commit intoochubar:masterfrom
Open
this arange does not get max k endpoint, change to linsapce#23dhidas wants to merge 1 commit intoochubar:masterfrom
dhidas wants to merge 1 commit intoochubar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original version is missing the max K by an amount dk. As N increases you get closer to the endpoint it becomes closer, but typically the max is somewhat important. I noticed this when trying to pull the max from N=2 where dk is large which was not giving the correct result. Suggest also checking for N=1 with different min/max.