GPU-related code changes, revised.#46
Draft
himanshugoel2797 wants to merge 9 commits intoochubar:masterfrom
Draft
GPU-related code changes, revised.#46himanshugoel2797 wants to merge 9 commits intoochubar:masterfrom
himanshugoel2797 wants to merge 9 commits intoochubar:masterfrom
Conversation
3cfb632 to
02637c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This incorporates most of the C++ side GPU related changes to SRW. Appears to compile fine and CPU tests pass. I think tagging of the changes should be much more thorough this time too.
Some points regarding parts which haven't been incorporated into this pull request:
srwl_bl.py) since we haven't really discussed the ideal way to integrate options here (eg how to specify gpu use for only propagation or only csd). These aren't on the critical path to having an initial release, and anyway the changes are relatively small.