Added scriptType and defaultScriptType#296
Open
Gigitsu wants to merge 2 commits intoocombe:masterfrom
Open
Conversation
…load js files with yield keyword
|
why we need specify version here? |
Author
|
Because, otherwise, loading js files that uses 'yield' or 'let' keywords with FireFox leads to an error. |
Collaborator
|
Hello @Gigitsu, I couldn't find such error on FireFox though I used 'let' or 'yield' on example codes. Could you suggest simple example, or let me know your browser version? |
|
Hi, do you know when will be merge this change with the master branch? I need this change like minimum because some security auditories said that my code need to say the type "text/javascript" to javascript files. This is important for our team to pass the auditory completly. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, ocLazyLoad doesn't add type attribute to script element. This led to an error when loading js file with 'yield' using FireFox, specifically the error is 'SyntaxError: yield is a reserved identifier'.
To let FireFox correctly recognize the js file, I need to put type type="application/javascript;version=1.8" in script element.
Now you can set the default script type attribute by configuration with
or directly with your router