Skip to content

Conversation

@n-arth
Copy link

@n-arth n-arth commented Nov 30, 2025

Pull request workflow

Resolves #ISSUE_NUMBER

I added the aspects from pina for pinch analysis and additional plotting functions. I also added comments for still needed functions as well as possibilities to connect to tespy. By now it can be seen as a seperated set of functions.

  • [ x] Implement unit tests for the changes --> done as an example, as the implementation is currently by plotting
  • [ x] For a new feature: Implement an example and a system test --> example as said above

I need help for those two aspects

  • Update the documentation
  • Update the changelog at docs/whats_new/*
    Additionally pina 0.1.1 is required. Add this the requirements

@fwitte
Copy link
Member

fwitte commented Dec 1, 2025

Hi @n-arth, thank you for pushing this topic! I'd suggest we meet and build a minimal example/integration with a tespy model (maybe using SimpleHeatExchanger instances to keep things simple).
Best

@fwitte fwitte changed the title Pinch Implement an example for pinch analysis through coupling tespy with pina Dec 15, 2025
@n-arth
Copy link
Author

n-arth commented Dec 21, 2025

Hi @fwitte I added the minimal example with the simple heat exchanger. Summarizing the previous messages and our conversations, there are the following aspects missing by now:

  • Update the documentation
  • Update the changelog at docs
  • Include pint / the network units
  • Include all heat exchanger types
  • Create some automated tests (the generated plots have to be reviewed manually)
  • add a commented example introducing pinch analysis and the functions
  • add automatic checks for integrated heat pumps regarding the pinch analysis conditions
  • add a new function to include any set of heat exchangers, in contrast to the heat pump with just two

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants