-
Notifications
You must be signed in to change notification settings - Fork 124
Implement an example for pinch analysis through coupling tespy with pina
#855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n-arth
wants to merge
20
commits into
oemof:dev
Choose a base branch
from
n-arth:pinch
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+438
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, as there is currently only plotting to check
Member
|
Hi @n-arth, thank you for pushing this topic! I'd suggest we meet and build a minimal example/integration with a tespy model (maybe using SimpleHeatExchanger instances to keep things simple). |
…lity/recovery sections
tespy with pina
Author
|
Hi @fwitte I added the minimal example with the simple heat exchanger. Summarizing the previous messages and our conversations, there are the following aspects missing by now:
Best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request workflow
Resolves #ISSUE_NUMBER
I added the aspects from pina for pinch analysis and additional plotting functions. I also added comments for still needed functions as well as possibilities to connect to tespy. By now it can be seen as a seperated set of functions.
I need help for those two aspects
Additionally pina 0.1.1 is required. Add this the requirements