Fixed build scripts on OSX to reference the correct filename for CEF hel...#24
Open
sheridanis wants to merge 2 commits intoofZach:masterfrom
Open
Fixed build scripts on OSX to reference the correct filename for CEF hel...#24sheridanis wants to merge 2 commits intoofZach:masterfrom
sheridanis wants to merge 2 commits intoofZach:masterfrom
Conversation
* commit '8cfa313341f8fa44d40d1e4b3d376cd83ca399f8': Fixed some typos. Updated the README for Windows support. The CefShutdown() on exit makes the app crash on OS X. Commented out for now. We still need to fix this on Windows. These flags only works for Windows. The screen stays black if used on OS X. Made the characters keys work on Windows. Need to see if this works on OS X as is or if we need to make it Windows specific. Created an exit() method in ofxCEF.cpp. The app still crashes when shutting down on Windows. Do the call to glfwSetScrollCallback only on OS X for now. It does not work on Windows, will see this when I need it. We may have moved to OF 0.9.0 or the Master branch before. Added some command line flags. The following one '--disable-d3d11` changed the performance quite a lot on Windows. (Still need to see if this last flag need to be omitted in ofxCEF when on OS X or if we let CEF deal with this). Continuing the unification of the API. Updated the permissions on these 2 files. I certainly had to do this because I did renamed the example's folder. Starting to unify the addon API for both OS X and Windows (this push from Windows is for me to be able to test on OS X). Initial commit of a working Visual Studio Solution. Generated the Visual Studio Solution. Renamed the example folder to work with the Projector Generator on Windows. Reorganized the way CEF is included in the addon (file system and in the project), in order to be able to other versions/platforms. readme fix add readme fixed braces to match OF style fixes for crashes on quiting osx Conflicts: example_ofxCEF/example-ofxCEF.xcodeproj/project.pbxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to make this change to get things to compile on OSX
ofx 0.8.4
osx 10.10
xcode 6.2