Pullrequest add authentication support #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 21, 2010 16:15
… if the JSON implementation is already included in the app.
Conflicts: HTTPRiot.xcodeproj/project.pbxproj
First implementation that integrates the ChallengeHandler into HTTPRiot (main code was taken from the AdvancedURLConnections example provided by Apple). This code is still untested but compiles. I'm currently not quite happy that we need to add a view controller as root for modal view controllers. But I don't see a better way now. Registering of authentication handlers (see ChallengeHandler method registerAllHandlers) needs improvements. It is still hard wired.
…ix unexpected autorelease ..
Owner
|
Hey! Definetly! The funny thing is that I implemented exactly the same thing a month ago but was too busy with day work projects to push it up stream. I also found some issues in NSURLConnection while at it. Tell you what: I'll push my branch as well and you look at it and tell me what you think. I will look at your pull request and we'll merge the best of both approaches to the master. Ognen |
Author
|
Ok. I'm looking forward to see your solution. :) |
Author
|
Hi! You wanted to publish your branch in order to decide which solution is the best! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Caged told me that you are managing the official fork of this project.
I have finished my integration of https authentication and would like to discuss whether it might be added into the main stream. The code works here in my local application.
It handles the two NSURLConnection delegate functions:
(BOOL)connection:(NSURLConnection )conn canAuthenticateAgainstProtectionSpace:(NSURLProtectionSpace )protectionSpace
(void)connection:(NSURLConnection )conn didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge )challenge
and adds a ChallengeHandler Class that is managing the incoming requests.
Todo:
The ChallengeHandler currently uses static Classnames for the various handlers. I would change this before merging.
Btw.: The code was taken from the great example "AdvancedURLConnections", provided by Apple.
What do you think?