Skip to content

Conversation

@ikogan
Copy link
Contributor

@ikogan ikogan commented Aug 22, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 22, 2025 19:21
@ikogan ikogan merged commit b7c7550 into main Aug 22, 2025
3 of 4 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tracing capabilities and the ability to pull the script from a different branch instead of being hardcoded to main. It also includes minor fixes for binary validation and conditional logic.

  • Introduces configurable branch selection via SCRIPT_SOURCE_BRANCH environment variable
  • Adds optional tracing mode through FORCE_TRACE_MODE environment variable
  • Updates binary requirements to include git and validates branch format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

git check-ref-format --branch "${SCRIPT_SOURCE_BRANCH}" >/dev/null || exit 1

if ! grep --help | grep -q 'extended-regexp'; then
error "❌ Error: Your version of grep does not support extended regular expressions. PPlease contact ADP for assistance and let us know what operating system you're using."
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the error message: "PPlease" should be "Please".

Suggested change
error "❌ Error: Your version of grep does not support extended regular expressions. PPlease contact ADP for assistance and let us know what operating system you're using."
error "❌ Error: Your version of grep does not support extended regular expressions. Please contact ADP for assistance and let us know what operating system you're using."

Copilot uses AI. Check for mistakes.
ikogan added a commit that referenced this pull request Sep 2, 2025
* Add tracing and ability to pull from a different branch

* Fix some output

* Add tracing and ability to pull from a different branch (#19) (#20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants