Added a little adp-connect debugging. #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a debug log message to provide better visibility when fetching kubeconfig files for Rancher clusters.
- Adds a debug message before the
gum spincommand to log cluster and server information during kubeconfig fetching
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for CLUSTER in $(rancher cluster list | grep -v CURRENT | sed 's/^*//g' | awk '{ print $1 }'); do | ||
| if [[ -z "${SKIP_KUBECONFIG}" ]]; then | ||
| TEMP_KUBE_CONFIG=$(echo "${SERVER}-${CLUSTER}" | base64) | ||
| debug "Fetching kubeconfig for cluster ${CLUSTER} on server ${SERVER}..." |
There was a problem hiding this comment.
The debug message on line 807 duplicates information already shown by the gum spin title on line 808. When HAVE_GUM is true and ENABLE_DEBUG is set, users will see both messages simultaneously, which is redundant. The debug message should either provide additional context (like the full file path where the config will be saved) or be removed to avoid duplication.
Suggested change
| debug "Fetching kubeconfig for cluster ${CLUSTER} on server ${SERVER}..." | |
| debug "Fetching kubeconfig for cluster ${CLUSTER} on server ${SERVER} (saving to ${TEMP_DIR}/${TEMP_KUBE_CONFIG}.yaml)..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.