fix: allow filtering on custom named types#212
Merged
ohler55 merged 1 commit intoohler55:developfrom Aug 16, 2025
Merged
Conversation
A custom named type being:
```
type Color string
```
A filter expression on the value `"blue"` would work normally,
while on the value `Color("blue")` it would silently never match.
This was unexpected and undocumented behavior, so I decided
to fix by supporting custom named types for all common types.
ohler55
approved these changes
Aug 16, 2025
Owner
|
Thank you. A nice improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom named type being:
A filter expression on the value
"blue"would work normally, while on the valueColor("blue")it would silently never match.This was unexpected and (as far as I could tell) undocumented behavior, so I decided to fix by supporting custom named types for all common types.