Conversation
Co-authored-by: oliver <oliver@meetelise.com>
|
Cursor Agent can help with this pull request. Just |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| except FileNotFoundError: | ||
| errors.append((cmd, "command not found")) | ||
| except Exception as e: | ||
| errors.append((cmd, str(e))) |
There was a problem hiding this comment.
Timeout may double when both commands are tried
Medium Severity
The timeout parameter applies per command attempt, not to the total operation. Since the loop tries both "soffice" and "libreoffice" sequentially, if the first command times out after 60 seconds, the second command will also be attempted with its own 60-second timeout. The actual maximum wait time could be 120 seconds, contradicting the documented 60-second timeout and the PR's stated intent.
Add a document conversion utility with a 60-second timeout to address previous 5-second timeout failures.
This utility was created as a reference in this repository because the actual document conversion code with the 5-second timeout is located in a different, inaccessible repository. The timeout for LibreOffice conversion has been increased from 5 seconds to 60 seconds (1 minute) to prevent premature timeouts for larger documents.
Slack Thread
Note
Introduces a lightweight LibreOffice-based document-to-PDF conversion utility with a longer timeout and clear failure reporting.
document_conversion.pywithconvert_to_pdfandconvert_document_to_pdfsoffice/libreoffice) to convert and returns the output pathWritten by Cursor Bugbot for commit a6e7450. This will update automatically on new commits. Configure here.