Draft
Conversation
Owner
Author
|
This PR is very slow compared to
This branch: |
|
Yeah it's not a huge surprise that this is way slower - speed absolutely was not one of the primary concerns for this project. It should be easy enough to rewrite with speed in mind (though I wonder if ruby is going to beat V8 regardless) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
sidtoolrelies on an atrocity of a gem I made for simulating the MOS 6510 CPU: https://github.com/olefriis/mos6510. That gem wraps a piece of JavaScript from https://github.com/jhohertz/jsSID. This is done with themini_racergem which wraps a V8 virtual machine. It's clearly overkill for solving this problem.Additionally, this is causing issues for people installing sidtool. So it would be interesting to try out a pure-Ruby solution. Incidentally my awesome colleague @wuest has implemented a MOS 6502 simulator (which is, for all practical purposes, the same as a MOS 6510 emulator): https://github.com/wuest/livestream-6502-emu
This PR just pastes all of the other repository into this. It's really not nice, but meant for experimenting.