Add Sentinel metrics to improve failover detection and monitoring capabilities #1078
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR! |
oliver006
reviewed
Jan 8, 2026
exporter/exporter.go
Outdated
| "sentinel_master_setting_failover_timeout": {txt: "Show the current failover-timeout config for each master", lbls: []string{"master_name", "master_address"}}, | ||
| "sentinel_master_setting_parallel_syncs": {txt: "Show the current parallel-syncs config for each master", lbls: []string{"master_name", "master_address"}}, | ||
| "sentinel_master_config_epoch": {txt: "The configuration epoch of the master (increments on each failover)", lbls: []string{"master_name", "master_address"}}, | ||
| "sentinel_master_last_ok_ping_reply_ms": {txt: "Elapsed time in milliseconds since the last successful ping reply from the master", lbls: []string{"master_name", "master_address"}}, |
Owner
There was a problem hiding this comment.
sentinel_master_last_ok_ping_reply_ms
base unit should be seconds - can you convert?
Author
There was a problem hiding this comment.
@oliver006
I have a question, doesn't the existing sentinel_master_setting_down_after_milliseconds use milliseconds instead of seconds?
Owner
There was a problem hiding this comment.
Yeah, they both should probably use _seconds
Author
There was a problem hiding this comment.
For now I only converted the units of the metrics I added
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
+ Coverage 81.85% 81.90% +0.04%
==========================================
Files 20 20
Lines 2657 2663 +6
==========================================
+ Hits 2175 2181 +6
Misses 362 362
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 20811912693Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Metrics
sentinel_master_config_epoch: The configuration epoch of the master (increments on each failover)
SENTINEL MASTERScommand responsemaster_name,master_addresssentinel_master_last_ok_ping_reply_ms: Elapsed time in milliseconds since the last successful ping reply
SENTINEL MASTERScommand responsemaster_name,master_addressChanges
config-epochfield extraction inextractSentinelMetrics()functionlast-ok-ping-replyfield extraction inextractSentinelMetrics()functionexporter.gocloses: #1077