[type] Move type definitions from DefinitelyTyped#609
Open
kodai3 wants to merge 6 commits intooliviertassinari:masterfrom
Open
[type] Move type definitions from DefinitelyTyped#609kodai3 wants to merge 6 commits intooliviertassinari:masterfrom
kodai3 wants to merge 6 commits intooliviertassinari:masterfrom
Conversation
kodai3
changed the title
This reverts commit ef093ee.
| "react-swipeable-views-core": "^0.13.7", | ||
| "shallow-equal": "^1.2.1" | ||
| "shallow-equal": "^1.2.1", | ||
| "@material-ui/types": "^4.0.0" |
Owner
There was a problem hiding this comment.
This seems unrelated
Suggested change
| "@material-ui/types": "^4.0.0" |
There was a problem hiding this comment.
@kodai3, are you planning to fix this PR? It's the last of 3 opened ones, I guess @oliviertassinari is waiting for it before a potential merge & publish
Owner
There was a problem hiding this comment.
I support the idea to have the types built in the library directly.
The types package of Material-UI is meant for internal usages so it shouldn't be here. As for the other pull requests. This one can be work on independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved type definition from
Closes #506
i just moved, but type could be updated for instance,
getDomTreeShapesandfindNativeHandlerare exported fromSwipeableViews.jsbut not defined on DefinitelyTyped.i didn't fix because i'm wondering theses should be exported
adding type test