refactor: remove login1 dependency, use reboot.target for reboot #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanZachmann
force-pushed
the
refactor-reboot
branch
2 times, most recently
from
fd44bfe to
adc2c4c
Compare
Replace the login1-based reboot implementation with a systemd unit-based approach using reboot.target. This removes the dependency on the login1 D-Bus interface and aligns the reboot operation with existing systemd unit management patterns in the codebase. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
JanZachmann
force-pushed
the
refactor-reboot
branch
from
adc2c4c to
6fff134
Compare
JanZachmann
changed the title
mlilien
approved these changes
Nov 18, 2025
empwilli
approved these changes
Nov 18, 2025
JanZachmann
added a commit
to JanZachmann/omnect-device-service
that referenced
this pull request
Nov 23, 2025
Complete the migration from login1.Manager.Reboot to reboot.target by updating the bash scripts that were missed in omnect#181. This ensures consistent reboot behavior across all code paths (Rust and bash) and proper systemd shutdown ordering. Changes: - systemd/omnect-device-service.exec_stop_post.sh: Replace dbus-send to login1 with systemctl start reboot.target - systemd/update-validation-observer.sh: Replace dbus-send to login1 with systemctl start reboot.target - Bump version to 0.41.14 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
JanZachmann
added a commit
to JanZachmann/omnect-device-service
that referenced
this pull request
Nov 23, 2025
Complete the migration from login1.Manager.Reboot to reboot.target by updating the bash scripts that were missed in omnect#181. This ensures consistent reboot behavior across all code paths (Rust and bash) and proper systemd shutdown ordering. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
JanZachmann
added a commit
that referenced
this pull request
Nov 24, 2025
## Summary Complete the migration from `login1.Manager.Reboot` to `reboot.target` by updating the bash scripts that were missed in #181. This ensures consistent reboot behavior across all code paths (Rust and bash) and proper systemd shutdown ordering. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the login1-based reboot implementation with a systemd unit-based
approach using reboot.target. This removes the dependency on the login1
D-Bus interface and aligns the reboot operation with existing systemd unit
management patterns in the codebase.